1. 11 Jun, 2014 1 commit
  2. 30 Apr, 2014 1 commit
    • Роман Донченко's avatar
      Avoid killing all available processes if an X error arrives early on · 3be60637
      Роман Донченко authored
      The timeline of events in dbus-launch's main process goes something like this:
      
      * do initial X calls
      [1]
      * do some other stuff
      * fork
          (child process starts doing some other stuff)
      * return "intermediate parent" pid from fork()
      * obtain bus daemon pid from bus_pid_to_launcher_pipe
      [2]
      * do things that might include X11 calls or killing the dbus-daemon
      
      Meanwhile, the "babysitter" child goes like this:
      
      * return 0 from fork()
      [3]
      * obtain bus daemon pid from parent process via bus_pid_to_babysitter_pipe
      [4]
      * do things that might include X11 calls or killing the bus daemon
      
      Before [1] or [3], the right thing to do about an X error is to just
      exit. The current implementation called kill(-1) first, which is
      undesirable: it kills unrelated processes. With this change, we
      just exit.
      
      After [2] or [4], the right thing to do is to kill the dbus-daemon,
      and that's what the existing code did.
      
      Between [1] and [2], or between [3] and [4], there is no correct thing
      that we can do immediately: we would have to wait for the end of the
      "critical section", *then* kill the dbus-daemon. This has not yet been
      implemented, so this patch relies for its correctness on the fact that
      there are no libX11 calls between those points, so we cannot receive
      an X error between them.
      
      dbus-launch deserves more comments, or a reimplementation that is easier to
      understand, but this change is certainly better than nothing.
      
      [Commit message added, summarizing reviewers' comments -smcv]
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74698
      Reviewed-by: Simon McVittie
      Reviewed-by: Thiago Macieira
      3be60637
  3. 06 Mar, 2014 1 commit
  4. 27 Nov, 2013 1 commit
  5. 09 Oct, 2013 3 commits
  6. 08 Oct, 2013 6 commits
  7. 16 Sep, 2013 3 commits
  8. 13 Sep, 2013 1 commit
    • Chengwei Yang's avatar
      Use test binaries in build dir to do test · ee0f28f6
      Chengwei Yang authored
      When do autolaunch testing, libdbus will try to start dbus-launch in
      installed direcotry, if fail then fall back to dbus-launch in $PATH.
      dbus-launch does a relative better thing to start dbus-daemon in build
      directory, however, in most of case, the build $prefix is different from
      the real prefix where dbus-daemon installed. So dbus-daemon will fail to
      start due to can't find its config file. And then dbus-launch will fall
      back to finally the installed dbus-daemon.
      
      This patch fix this behavior and will start dbus-launch and dbus-daemon
      in build directory in test environment.
      
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37849
      ee0f28f6
  9. 05 Sep, 2013 3 commits
  10. 23 Aug, 2013 1 commit
  11. 19 Aug, 2013 1 commit
  12. 28 Jun, 2013 1 commit
  13. 26 Jun, 2013 4 commits
  14. 20 Jun, 2013 1 commit
  15. 13 Jun, 2013 1 commit
  16. 06 Jun, 2013 1 commit
  17. 05 Jun, 2013 2 commits
  18. 10 May, 2013 1 commit
  19. 22 Feb, 2013 1 commit
  20. 09 Nov, 2012 1 commit
  21. 18 Jul, 2012 1 commit
  22. 27 Jun, 2012 1 commit
  23. 25 Jun, 2012 1 commit
  24. 15 Jun, 2012 2 commits