1. 06 Nov, 2018 13 commits
  2. 05 Nov, 2018 1 commit
  3. 03 Nov, 2018 1 commit
  4. 31 Oct, 2018 1 commit
  5. 24 Oct, 2018 1 commit
  6. 23 Oct, 2018 1 commit
  7. 22 Oct, 2018 1 commit
    • Lubomir Rintel's avatar
      agetty: don't put the VC into canonical mode · 8b58ffdd
      Lubomir Rintel authored
      The wait_for_term_input()'s select() needs to be tripped when the user
      starts typing. Otherwise the reloads can abort an already in-progress login.
      
      Coupled with \4 and \6 expansions that happen to be there on Fedora Server,
      this means reload on every netlink event. With a couple of IPv6 routers
      announcing their networks and temporary addresses in use can make it
      sometimes virtually impossible to log in.
      
      Seems like zero lflags do the job just fine on a Linux VT. Reset it to
      canonical mode before running login.
      Signed-off-by: 's avatarLubomir Rintel <lkundrak@v3.sk>
      Signed-off-by: 's avatarStanislav Brabec <sbrabec@suse.cz>
      Signed-off-by: 's avatarKarel Zak <kzak@redhat.com>
      8b58ffdd
  8. 19 Oct, 2018 4 commits
  9. 11 Oct, 2018 7 commits
    • Karel Zak's avatar
      agetty: don't use __u32 · cdd538e3
      Karel Zak authored
      Signed-off-by: 's avatarKarel Zak <kzak@redhat.com>
      cdd538e3
    • Karel Zak's avatar
      agetty: make output more robust · 056a370e
      Karel Zak authored
      Signed-off-by: 's avatarKarel Zak <kzak@redhat.com>
      056a370e
    • Karel Zak's avatar
      agetty: cleanup issue output change, remove bool · 980a6e43
      Karel Zak authored
      Signed-off-by: 's avatarKarel Zak <kzak@redhat.com>
      980a6e43
    • Karel Zak's avatar
      agetty: move all issue variables to struct · ddbb3067
      Karel Zak authored
      Signed-off-by: 's avatarKarel Zak <kzak@redhat.com>
      ddbb3067
    • Stanislav Brabec's avatar
      agetty: Reload only if it is really needed · 6522d88d
      Stanislav Brabec authored
      If netlink event arrives and related escapes are part of issue, agetty
      reloads and re-display the prompt. Reload is triggered not only by IP
      address change, but also by IPv6 RAs. In some environments it causes
      reload several times in a minute, and even complicates the login.
      
      To prevent this, reload only if a real change appears.
      
      This consists of:
      split print_issue_file() to several functions:
      
      eval_issue_file() prints issue to memory. It does not affect terminal in
      any way.
      
      print_issue_file() prints issue file from memory.
      
      cmp_issue_file() compares the issue file and returns true, if reload is
      needed.
      
      The implementation requires additional change:
      
      do_prompt() does not evaluate the issue file. It is responsibility of
      calling function.
      
      Test suite:
      
      Use issue that contais \4 and/or \6 escape.
      
      After installing new instance, restart agetty by typing a letter and then
      Enter 6 times.
      
      To check whether reload happens, type a letter. When reload happens,
      letter disappears.
      
      1. Unplug network cable. Wait a while and re-plug network cable.
      You should see 2 reloads on single stack and 3 reloads on dual stack.
      
      2. Run a loop
      while : ; do
      	sed -i '$areload_test' /etc/issue
      	agetty --reload
      	sleep 3
      	sed -i '/reload_test/d' /etc/issue
      	agetty --reload
      	sleep 3
      done
      You should see regular reload every 3 seconds.
      
      3. Run a loop
      while : ; do
      	agetty --reload
      	sleep 3
      done
      Before: You see regular reload every 3 seconds.
      After: No reloads.
      
      4. Run a loop
      while : ; do
      	ifconfig lo 127.0.0.1 netmask 255.0.0.0
      	sleep 3
      	ifconfig lo 127.0.0.2 netmask 255.0.0.0
      	sleep 3
      done
      Before: You see regular reload every 3 seconds.
      After: No reloads.
      Signed-off-by: 's avatarStanislav Brabec <sbrabec@suse.cz>
      6522d88d
    • Stanislav Brabec's avatar
      agetty: Watch only protocol requested by issue escapes · 36c55a89
      Stanislav Brabec authored
      To decrease number of reloads, watch only protocol requested by \4 and \6
      escapes in issue file.
      Signed-off-by: 's avatarStanislav Brabec <sbrabec@suse.cz>
      36c55a89
    • Stanislav Brabec's avatar
      agetty: rename variable changed to triggered · c5955394
      Stanislav Brabec authored
      changed variable name is not correct. It does not say that network
      interface changed its address. It just says that the netlink message
      processing was triggered.
      Signed-off-by: 's avatarStanislav Brabec <sbrabec@suse.cz>
      c5955394
  10. 05 Oct, 2018 4 commits
  11. 04 Oct, 2018 6 commits