Browse Source

fix: Consecutive return, break, continue, goto or throw statements are unnecessary.

Git-Dch: Ignore
Reported-By: cppcheck
debian/1.8.y
David Kalnischkies 8 years ago
parent
commit
5e49cbb7b6
  1. 1
      apt-inst/dirstream.cc
  2. 4
      apt-pkg/contrib/fileutl.cc

1
apt-inst/dirstream.cc

@ -76,7 +76,6 @@ bool pkgDirStream::DoItem(Item &Itm,int &Fd)
if(mkdir(Itm.Name,Itm.Mode) < 0)
return false;
return true;
break;
}
case Item::FIFO:
break;

4
apt-pkg/contrib/fileutl.cc

@ -2126,10 +2126,8 @@ bool Popen(const char* Args[], FileFd &Fd, pid_t &Child, FileFd::OpenMode Mode)
int Pipe[2] = {-1, -1};
if(pipe(Pipe) != 0)
{
return _error->Errno("pipe", _("Failed to create subprocess IPC"));
return NULL;
}
std::set<int> keep_fds;
keep_fds.insert(Pipe[0]);
keep_fds.insert(Pipe[1]);

Loading…
Cancel
Save