devuan
/
documentation
17
5
Fork 7
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones

Fix broken image link #6

Merged
plasma41 merged 2 commits from sakrecoer/documentation:sakrecoer-patch-1 into master 3 months ago
Conversation 8 Commits 2 Files Changed 1
sakrecoer commented 4 months ago

The readme file in the art folder has a broken image link.
This commit links the image in the readme-file directly to
the image contained in the repo itself.
(hope i'm doing this right (^^,) )

The readme file in the `art` folder has a broken image link. This commit links the image in the readme-file directly to the image contained in the repo itself. (hope i'm doing this right (^^,) )
sakrecoer added 1 commit 4 months ago
bbonev commented 4 months ago
Owner

Looks good to me, that svg logo is no longer on the web site

Looks good to me, that svg logo is no longer on the web site
golinux commented 4 months ago

Discussed at the last meet. All the logos have been tracked down (some are on www). The broken gitea symlinks will be removed and alternate access to the logos provided

Discussed at the last meet. All the logos have been tracked down (some are on www). The broken gitea symlinks will be removed and alternate access to the logos provided
plasma41 commented 4 months ago
Collaborator

@sakrecoer, Could you modify your commit to replace the old link with a relative rather than an absolute link?

In other words

./art/graphics/logo/devuan-logo.svg

rather than

https://git.devuan.org/devuan/documentation/raw/branch/master/art/graphics/logo/devuan-logo.svg

Also, while looking into the history of this issue, I uncovered some context that might be worth including in the commit message. Feel free to modify this:

The original version of this link in this README.md was introduced in commit 023a03cb173eb4e2ed731ee6ab9e368bd5b0a50d of the devuan-art repository (that repo having since been merged into this one) and initially pointed to 'logo-devuan.svg' [sic]. At the time of that commit, 'devuan-logo.svg' in the top level directory was a symlink to the file 'graphics/logo/devuan-logo.svg' in the repository. Because 'logo-devuan.svg' != 'devuan-logo.svg', the image failed to display in the README.md.

In commit 03f1879d5117e5e49d5d51549f59bbc7e7240dc9 of the devuan-art repository this was "fixed" by changing the link to point to where the logo image was hosted on the beta.devuan.org at the time. However, the commit message incorrectly attributed the problem to an issue with "Gitlab's SVG view".
@sakrecoer, Could you modify your commit to replace the old link with a relative rather than an absolute link? In other words ./art/graphics/logo/devuan-logo.svg rather than https://git.devuan.org/devuan/documentation/raw/branch/master/art/graphics/logo/devuan-logo.svg Also, while looking into the history of this issue, I uncovered some context that might be worth including in the commit message. Feel free to modify this: ``` The original version of this link in this README.md was introduced in commit 023a03cb173eb4e2ed731ee6ab9e368bd5b0a50d of the devuan-art repository (that repo having since been merged into this one) and initially pointed to 'logo-devuan.svg' [sic]. At the time of that commit, 'devuan-logo.svg' in the top level directory was a symlink to the file 'graphics/logo/devuan-logo.svg' in the repository. Because 'logo-devuan.svg' != 'devuan-logo.svg', the image failed to display in the README.md. In commit 03f1879d5117e5e49d5d51549f59bbc7e7240dc9 of the devuan-art repository this was "fixed" by changing the link to point to where the logo image was hosted on the beta.devuan.org at the time. However, the commit message incorrectly attributed the problem to an issue with "Gitlab's SVG view". ```
golinux commented 3 months ago

These are links to logos and symbols that IMO should probably be linked here:

  1. This logo is the only "bare" logo (no copyright) and it is a .png. Plasma searched and could not find an svg anywhere:

https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/devuan-logo-1000x200.png

  1. This is the "swoosh" icon that Hellekin based on the orbit of Ceres:

Swoosh: https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/logo/devuan-emblem.svg

  1. This is the logo With detailed Copyright. There is also one with just the "c" at the lower right side of the log0:

https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/logo/devuan-logo.svg

https://git.devuan.org/devuan/www.devuan.org/src/branch/devuan.org/source/ui/img/devuan-logo-with-registered-trademark-sign.svg

  1. IMO, the if.png on the index page of www should also be included here as it is an iconic statement of Devuan's purpose. Take note that the text was changed last year to "init freedom take your first step".

https://git.devuan.org/devuan/www.devuan.org/src/branch/release-chimaera2daedalus/source/ui/img/if.png

FYI . . . the old if.png can be found here but does NOT need to be linked here:
https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/init-freedom

  1. A text message mentioning that there are various other icons and symbols used for different purposes and different releases scattered throughout:

https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics

Since I do not get on well with gitea, one of you will have to deal with these links . . . or not . . .

golinux

PS. also note that there are THREE broken icon links on:

https://git.devuan.org/devuan/documentation/src/branch/master/art

devuan-emblem.svg
devuan-logo.svg

In addition to the Devuan Logo SVG in the readme

These are links to logos and symbols that IMO should probably be linked here: 1. This logo is the only "bare" logo (no copyright) and it is a .png. Plasma searched and could not find an svg anywhere: https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/devuan-logo-1000x200.png 2. This is the "swoosh" icon that Hellekin based on the orbit of Ceres: Swoosh: https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/logo/devuan-emblem.svg 3. This is the logo With detailed Copyright. There is also one with just the "c" at the lower right side of the log0: https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/logo/devuan-logo.svg https://git.devuan.org/devuan/www.devuan.org/src/branch/devuan.org/source/ui/img/devuan-logo-with-registered-trademark-sign.svg 4. IMO, the if.png on the index page of www should also be included here as it is an iconic statement of Devuan's purpose. Take note that the text was changed last year to "init freedom take your first step". https://git.devuan.org/devuan/www.devuan.org/src/branch/release-chimaera2daedalus/source/ui/img/if.png FYI . . . the old if.png can be found here but does NOT need to be linked here: https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/init-freedom 5. A text message mentioning that there are various other icons and symbols used for different purposes and different releases scattered throughout: https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics Since I do not get on well with gitea, one of you will have to deal with these links . . . or not . . . golinux PS. also note that there are THREE broken icon links on: https://git.devuan.org/devuan/documentation/src/branch/master/art devuan-emblem.svg devuan-logo.svg In addition to the Devuan Logo SVG in the readme
sakrecoer commented 3 months ago
Poster

Thank you @plasma41 and @golinux !

@plasma: Sadly, when i use ./art/graphics/logo/devuan-logo.svg the path fails. However ./graphics/logo/devuan-logo.svg did the job. I have no way to make sure the path will work when merged back to upstream, but i am committing it anyways, including your adendum in the commit messsage. Feel free to disregard this fork if it doesn't cut the smol fix.

Regarding adding additional graphic material in the README.md, should i make a layout proposal or would you prefer instruing me on a layout proposal, @golinux? I'm happy with both :)

Thank you @plasma41 and @golinux ! @plasma: Sadly, when i use `./art/graphics/logo/devuan-logo.svg` the path fails. However `./graphics/logo/devuan-logo.svg` did the job. I have no way to make sure the path will work when merged back to upstream, but i am committing it anyways, including your adendum in the commit messsage. Feel free to disregard this fork if it doesn't cut the smol fix. Regarding adding additional graphic material in the `README.md`, should i make a layout proposal or would you prefer instruing me on a layout proposal, @golinux? I'm happy with both :)
sakrecoer added 1 commit 3 months ago
0fa1af0be5 Make image path a relative URL
golinux commented 3 months ago

@ sakrecoer

Here's a proposal for revising the README. Suggestions for improvements are welcome:

  1. Remove these links from https://git.devuan.org/devuan/documentation/src/branch/master/art

===================
devuan-emblem.svg - broken symlink
devuan-logo.svg - broken symlink
init-freedom.markdown - deprecated format

===================

  1. Remove the "Logo" section:

===================
Logo

The Devuan logo source files and specifications are in [graphics/logo][logo].

Devuan Logo SVG

===================

  1. Rewrite the Logo section to this:

Devuan Logos and Icons

A variety of square and round icons themed for various Devuan releases and purposes can be found HERE (link to https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics)

@ sakrecoer Here's a proposal for revising the README. Suggestions for improvements are welcome: 1. Remove these links from https://git.devuan.org/devuan/documentation/src/branch/master/art =================== devuan-emblem.svg - broken symlink devuan-logo.svg - broken symlink init-freedom.markdown - deprecated format =================== 2. Remove the "Logo" section: =================== Logo The Devuan logo source files and specifications are in [graphics/logo][logo]. Devuan Logo SVG =================== 3. Rewrite the Logo section to this: Devuan Logos and Icons - devuan-logo.svg (link to https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/logo/devuan-logo.svg) - with verbose Copyright info - devuan-logo-with-registered-trademark-sign.svg (link to https://git.devuan.org/devuan/www.devuan.org/src/branch/devuan.org/source/ui/img/devuan-logo-with-registered-trademark-sign.svg) - with small Copyright symbol - devuan-logo-1000x200.png (link to https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/devuan-logo-1000x200.png) - with no Copyright info - devuan-emblem.svg (link to https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/logo/devuan-emblem.svg) - the "swoosh" icon based on the orbit of Ceres - if.png (https://git.devuan.org/devuan/www.devuan.org/src/branch/release-chimaera2daedalus/source/ui/img/if.png) - Revised "init-freedom" graphic for current release. The now deprecated original "if.svg" can be found here (link to https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics/init-freedom/if.svg) A variety of square and round icons themed for various Devuan releases and purposes can be found HERE (link to https://git.devuan.org/devuan/documentation/src/branch/master/art/graphics)
plasma41 commented 3 months ago
Collaborator

@plasma: Sadly, when i use ./art/graphics/logo/devuan-logo.svg the path fails. However ./graphics/logo/devuan-logo.svg did the job.

@sakrecoer Oops. Yes, I was off-by-one for the starting point of the path. What you used is what I should have said to use in the first place.

> @plasma: Sadly, when i use `./art/graphics/logo/devuan-logo.svg` the path fails. However `./graphics/logo/devuan-logo.svg` did the job. @sakrecoer Oops. Yes, I was off-by-one for the starting point of the path. What you used is what I should have said to use in the first place.
plasma41 commented 3 months ago
Collaborator

@golinux, I'm going to go ahead and merge @sakrecoer's changes as-is, and open a seperate issue for revising the README based on your proprosal.

@golinux, I'm going to go ahead and merge @sakrecoer's changes as-is, and open a seperate issue for revising the README based on your proprosal.
plasma41 merged commit a4e3045ea1 into master 3 months ago
The pull request has been merged as a4e3045ea1.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
experimental unstable
No Label experimental unstable
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'sakrecoer/documentation:sakrecoer-patch-1'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes